From 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Tue, 4 Jan 2022 13:59:09 +0100 Subject: PHPStan level 5 (#4110) * Fix most PHPDocs errors Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 https://phpstan.org/writing-php-code/phpdoc-types * Avoid func_get_args Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list And avoid dynamic functions names when possible to more easily identify calls and unused functions. Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 * PHPStan level 3 * PHPStand level 4 * Update default to PHPStan level 4 * Towards level 5 * Fix level 4 regression * Towards level 5 * Pass PHPStan level 5 * Towards level 6 * Remove erronenous regression from changelog https://github.com/FreshRSS/FreshRSS/pull/4116 --- app/Services/ImportService.php | 4 ---- 1 file changed, 4 deletions(-) (limited to 'app/Services/ImportService.php') diff --git a/app/Services/ImportService.php b/app/Services/ImportService.php index 5db640455..4cc38c15c 100644 --- a/app/Services/ImportService.php +++ b/app/Services/ImportService.php @@ -4,9 +4,6 @@ * Provide methods to import files. */ class FreshRSS_Import_Service { - /** @var string */ - private $username; - /** @var FreshRSS_CategoryDAO */ private $catDAO; @@ -21,7 +18,6 @@ class FreshRSS_Import_Service { public function __construct($username) { require_once(LIB_PATH . '/lib_opml.php'); - $this->username = $username; $this->catDAO = FreshRSS_Factory::createCategoryDao($username); $this->feedDAO = FreshRSS_Factory::createFeedDao($username); } -- cgit v1.2.3