From 62f32ccadff77594f5b8e3ad24c4c2541ff35885 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Thu, 7 Aug 2025 22:19:45 +0200 Subject: PHPStan: finalise strictArrayFilter (#7794) As well as reportPossiblyNonexistentConstantArrayOffset. And disable PHPStan-next from GitHub Action, since the work is completed for now. --- cli/CliOption.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'cli/CliOption.php') diff --git a/cli/CliOption.php b/cli/CliOption.php index e92fbd804..129d0de03 100644 --- a/cli/CliOption.php +++ b/cli/CliOption.php @@ -5,6 +5,7 @@ final class CliOption { public const VALUE_NONE = 'none'; public const VALUE_REQUIRED = 'required'; public const VALUE_OPTIONAL = 'optional'; + /** @var 'none'|'required'|'optional' $valueTaken */ private string $valueTaken = self::VALUE_REQUIRED; /** @var array{type:string,isArray:bool} $types */ private array $types = ['type' => 'string', 'isArray' => false]; @@ -61,6 +62,7 @@ final class CliOption { return $this; } + /** @return 'none'|'required'|'optional' */ public function getValueTaken(): string { return $this->valueTaken; } @@ -94,6 +96,6 @@ final class CliOption { $this->deprecatedAlias, ]; - return array_filter($aliases); + return array_filter($aliases, fn(?string $alias): bool => $alias !== null && trim($alias) !== ''); } } -- cgit v1.2.3