From 6e2f2f1c1e98ecd86aa89c6547beb742d7385d18 Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Thu, 11 May 2023 13:02:04 +0200
Subject: A few additional PHPStan rules (#5388)

A subset of
https://github.com/phpstan/phpstan-strict-rules
---
 cli/i18n/I18nData.php           | 2 +-
 cli/i18n/I18nUsageValidator.php | 4 ++--
 cli/i18n/I18nValue.php          | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'cli/i18n')

diff --git a/cli/i18n/I18nData.php b/cli/i18n/I18nData.php
index 62ffd7ce1..9eb67406c 100644
--- a/cli/i18n/I18nData.php
+++ b/cli/i18n/I18nData.php
@@ -236,7 +236,7 @@ class I18nData {
 	 * @throws Exception
 	 */
 	public function addValue(string $key, string $value, string $language): void {
-		if (!in_array($language, $this->getAvailableLanguages())) {
+		if (!in_array($language, $this->getAvailableLanguages(), true)) {
 			throw new Exception('The selected language does not exist.');
 		}
 		if (!array_key_exists($this->getFilenamePrefix($key), $this->data[static::REFERENCE_LANGUAGE]) ||
diff --git a/cli/i18n/I18nUsageValidator.php b/cli/i18n/I18nUsageValidator.php
index f507fbac3..0d85077f0 100644
--- a/cli/i18n/I18nUsageValidator.php
+++ b/cli/i18n/I18nUsageValidator.php
@@ -42,10 +42,10 @@ class I18nUsageValidator implements I18nValidatorInterface {
 		foreach ($this->reference as $file => $data) {
 			foreach ($data as $key => $value) {
 				$this->totalEntries++;
-				if (preg_match('/\._$/', $key) && in_array(preg_replace('/\._$/', '', $key), $this->code)) {
+				if (preg_match('/\._$/', $key) && in_array(preg_replace('/\._$/', '', $key), $this->code, true)) {
 					continue;
 				}
-				if (!in_array($key, $this->code)) {
+				if (!in_array($key, $this->code, true)) {
 					$this->result .= sprintf('Unused key %s - %s', $key, $value) . PHP_EOL;
 					$this->failedEntries++;
 					continue;
diff --git a/cli/i18n/I18nValue.php b/cli/i18n/I18nValue.php
index c4746de03..295e5473e 100644
--- a/cli/i18n/I18nValue.php
+++ b/cli/i18n/I18nValue.php
@@ -24,7 +24,7 @@ class I18nValue {
 		}
 
 		$state = array_shift($data);
-		if (in_array($state, self::STATES)) {
+		if (in_array($state, self::STATES, true)) {
 			$this->state = $state;
 		}
 	}
-- 
cgit v1.2.3