From 7156a646b28dbdd848fe39acce3e9ba67d880410 Mon Sep 17 00:00:00 2001 From: ealdraed Date: Fri, 23 Jan 2015 01:48:02 +0100 Subject: Fix double quotes not escaped in RSS title (share by email) If an RSS feed title contains double quotes, this prematurely terminates the subject line and prohibits the URL to be added to the email body when using Share->Email. Replace urlencode() with rawurlencode() for all transform functions. --- data/shares.php | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'data') diff --git a/data/shares.php b/data/shares.php index 44176f1bf..6e0e9ea0c 100644 --- a/data/shares.php +++ b/data/shares.php @@ -19,7 +19,7 @@ return array( 'shaarli' => array( 'url' => '~URL~?post=~LINK~&title=~TITLE~&source=FreshRSS', - 'transform' => array('urlencode'), + 'transform' => array('rawurlencode'), 'help' => 'http://sebsauvage.net/wiki/doku.php?id=php:shaarli', 'form' => 'advanced', ), @@ -40,31 +40,28 @@ return array( ), 'diaspora' => array( 'url' => '~URL~/bookmarklet?url=~LINK~&title=~TITLE~', - 'transform' => array('urlencode'), + 'transform' => array('rawurlencode'), 'help' => 'https://diasporafoundation.org/', 'form' => 'advanced', ), 'twitter' => array( 'url' => 'https://twitter.com/share?url=~LINK~&text=~TITLE~', - 'transform' => array('urlencode'), + 'transform' => array('rawurlencode'), 'form' => 'simple', ), 'g+' => array( 'url' => 'https://plus.google.com/share?url=~LINK~', - 'transform' => array('urlencode'), + 'transform' => array('rawurlencode'), 'form' => 'simple', ), 'facebook' => array( 'url' => 'https://www.facebook.com/sharer.php?u=~LINK~&t=~TITLE~', - 'transform' => array('urlencode'), + 'transform' => array('rawurlencode'), 'form' => 'simple', ), 'email' => array( 'url' => 'mailto:?subject=~TITLE~&body=~LINK~', - 'transform' => array( - 'link' => array('urlencode'), - 'title' => array(), - ), + 'transform' => array('rawurlencode'), 'form' => 'simple', ), 'print' => array( -- cgit v1.2.3