From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- lib/Minz/Configuration.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lib/Minz/Configuration.php') diff --git a/lib/Minz/Configuration.php b/lib/Minz/Configuration.php index 18fa6e7df..5c3a8ade0 100644 --- a/lib/Minz/Configuration.php +++ b/lib/Minz/Configuration.php @@ -27,6 +27,7 @@ class Minz_Configuration { * @param string $config_filename the filename of the configuration * @param string $default_filename a filename containing default values for the configuration * @param Minz_ConfigurationSetterInterface $configuration_setter an optional helper to set values in configuration + * @throws Minz_FileNotExistException */ public static function register(string $namespace, string $config_filename, string $default_filename = null, Minz_ConfigurationSetterInterface $configuration_setter = null): void { @@ -103,6 +104,7 @@ class Minz_Configuration { * @param string $config_filename the file containing configuration values. * @param string $default_filename the file containing default values, null by default. * @param Minz_ConfigurationSetterInterface $configuration_setter an optional helper to set values in configuration + * @throws Minz_FileNotExistException */ private final function __construct(string $namespace, string $config_filename, string $default_filename = null, Minz_ConfigurationSetterInterface $configuration_setter = null) { @@ -153,7 +155,6 @@ class Minz_Configuration { * @param string $key the name of the param. * @param mixed $default default value to return if key does not exist. * @return array|mixed value corresponding to the key. - * @throws Minz_ConfigurationParamException if the param does not exist */ public function param(string $key, $default = null) { if (isset($this->data[$key])) { -- cgit v1.2.3