From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- lib/Minz/Exception.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'lib/Minz/Exception.php') diff --git a/lib/Minz/Exception.php b/lib/Minz/Exception.php index c306a14ca..283b28f4e 100644 --- a/lib/Minz/Exception.php +++ b/lib/Minz/Exception.php @@ -6,13 +6,13 @@ class Minz_Exception extends Exception { const WARNING = 10; const NOTICE = 20; - public function __construct(string $message, int $code = self::ERROR) { - if ($code != Minz_Exception::ERROR - && $code != Minz_Exception::WARNING - && $code != Minz_Exception::NOTICE) { + public function __construct(string $message = '', int $code = self::ERROR, ?Throwable $previous = null) { + if ($code !== Minz_Exception::ERROR + && $code !== Minz_Exception::WARNING + && $code !== Minz_Exception::NOTICE) { $code = Minz_Exception::ERROR; } - parent::__construct ($message, $code); + parent::__construct($message, $code, $previous); } } -- cgit v1.2.3