From 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Tue, 4 Jan 2022 13:59:09 +0100 Subject: PHPStan level 5 (#4110) * Fix most PHPDocs errors Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 https://phpstan.org/writing-php-code/phpdoc-types * Avoid func_get_args Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list And avoid dynamic functions names when possible to more easily identify calls and unused functions. Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 * PHPStan level 3 * PHPStand level 4 * Update default to PHPStan level 4 * Towards level 5 * Fix level 4 regression * Towards level 5 * Pass PHPStan level 5 * Towards level 6 * Remove erronenous regression from changelog https://github.com/FreshRSS/FreshRSS/pull/4116 --- lib/Minz/ExtensionManager.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib/Minz/ExtensionManager.php') diff --git a/lib/Minz/ExtensionManager.php b/lib/Minz/ExtensionManager.php index 576064b35..2b42708f8 100644 --- a/lib/Minz/ExtensionManager.php +++ b/lib/Minz/ExtensionManager.php @@ -210,7 +210,7 @@ class Minz_ExtensionManager { * * The extension init() method will be called. * - * @param Minz_Extension $ext_name is the name of a valid extension present in $ext_list. + * @param string $ext_name is the name of a valid extension present in $ext_list. */ public static function enable($ext_name) { if (isset(self::$ext_list[$ext_name])) { @@ -295,8 +295,8 @@ class Minz_ExtensionManager { * array keys. * * @param string $hook_name the hook to call. - * @param array $args additional parameters (for signature, please see self::$hook_list). - * @return mixed final result of the called hook. + * @param mixed $args additional parameters (for signature, please see self::$hook_list). + * @return mixed|null final result of the called hook. */ public static function callHook($hook_name, ...$args) { if (!isset(self::$hook_list[$hook_name])) { @@ -328,7 +328,7 @@ class Minz_ExtensionManager { * * @param string $hook_name is the hook to call. * @param mixed $arg is the argument to pass to the first extension hook. - * @return mixed final chained result of the hooks. If nothing is changed, + * @return mixed|null final chained result of the hooks. If nothing is changed, * the initial argument is returned. */ private static function callOneToOne($hook_name, $arg) { -- cgit v1.2.3