From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- lib/Minz/ModelArray.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'lib/Minz/ModelArray.php') diff --git a/lib/Minz/ModelArray.php b/lib/Minz/ModelArray.php index 090536623..f12e23567 100644 --- a/lib/Minz/ModelArray.php +++ b/lib/Minz/ModelArray.php @@ -24,7 +24,11 @@ class Minz_ModelArray { $this->filename = $filename; } - /** @return array */ + /** + * @return array + * @throws Minz_FileNotExistException + * @throws Minz_PermissionDeniedException + */ protected function loadArray(): array { if (!file_exists($this->filename)) { throw new Minz_FileNotExistException($this->filename, Minz_Exception::WARNING); @@ -46,6 +50,7 @@ class Minz_ModelArray { /** * Sauve le tableau $array dans le fichier $filename * @param array $array + * @throws Minz_PermissionDeniedException */ protected function writeArray(array $array): bool { if (file_put_contents($this->filename, "