From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- lib/favicons.php | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) (limited to 'lib/favicons.php') diff --git a/lib/favicons.php b/lib/favicons.php index df893b309..48b649c28 100644 --- a/lib/favicons.php +++ b/lib/favicons.php @@ -13,16 +13,12 @@ function isImgMime(string $content): bool { return true; } $isImage = true; - try { - /** @var finfo $fInfo */ - $fInfo = finfo_open(FILEINFO_MIME_TYPE); - /** @var string $content */ - $content = finfo_buffer($fInfo, $content); - $isImage = strpos($content, 'image') !== false; - finfo_close($fInfo); - } catch (Exception $e) { - syslog(LOG_WARNING, 'FreshRSS favicon error: ' . $e->getMessage()); - } + /** @var finfo $fInfo */ + $fInfo = finfo_open(FILEINFO_MIME_TYPE); + /** @var string $content */ + $content = finfo_buffer($fInfo, $content); + $isImage = strpos($content, 'image') !== false; + finfo_close($fInfo); return $isImage; } -- cgit v1.2.3