From 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Tue, 4 Jan 2022 13:59:09 +0100 Subject: PHPStan level 5 (#4110) * Fix most PHPDocs errors Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 https://phpstan.org/writing-php-code/phpdoc-types * Avoid func_get_args Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list And avoid dynamic functions names when possible to more easily identify calls and unused functions. Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 * PHPStan level 3 * PHPStand level 4 * Update default to PHPStan level 4 * Towards level 5 * Fix level 4 regression * Towards level 5 * Pass PHPStan level 5 * Towards level 6 * Remove erronenous regression from changelog https://github.com/FreshRSS/FreshRSS/pull/4116 --- lib/lib_install.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'lib/lib_install.php') diff --git a/lib/lib_install.php b/lib/lib_install.php index 82c98d646..886fff54c 100644 --- a/lib/lib_install.php +++ b/lib/lib_install.php @@ -41,9 +41,13 @@ function checkRequirements($dbType = '') { $xml = function_exists('xml_parser_create'); $json = function_exists('json_encode'); $mbstring = extension_loaded('mbstring'); + // @phpstan-ignore-next-line $data = DATA_PATH && is_writable(DATA_PATH); + // @phpstan-ignore-next-line $cache = CACHE_PATH && is_writable(CACHE_PATH); + // @phpstan-ignore-next-line $tmp = TMP_PATH && is_writable(TMP_PATH); + // @phpstan-ignore-next-line $users = USERS_PATH && is_writable(USERS_PATH); $favicons = is_writable(join_path(DATA_PATH, 'favicons')); @@ -73,7 +77,7 @@ function checkRequirements($dbType = '') { } function generateSalt() { - return sha1(uniqid(mt_rand(), true).implode('', stat(__FILE__))); + return sha1(uniqid('' . mt_rand(), true).implode('', stat(__FILE__))); } function initDb() { -- cgit v1.2.3