From 877f5f539b82db2e59ecf7257fce18dc9245f310 Mon Sep 17 00:00:00 2001 From: Marien Fressinaud Date: Tue, 14 Jul 2020 10:25:48 +0200 Subject: fix: Test setupMigrations doesn't return false (#3113) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `file_put_contents` can return 0 if there’s nothing to write in the `applied_migrations.txt` file, which is equivalent to `false`. Since there are no migrations yet, this is what happens. Because this value (i.e. `0`) is tested next in the `app/install.php` file, the install script was failing. --- lib/lib_install.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/lib_install.php') diff --git a/lib/lib_install.php b/lib/lib_install.php index e650a20b3..f171deb4a 100644 --- a/lib/lib_install.php +++ b/lib/lib_install.php @@ -127,5 +127,5 @@ function setupMigrations() { $migrator = new Minz_Migrator($migrations_path); $versions = implode("\n", $migrator->versions()); - return @file_put_contents($migrations_version_path, $versions); + return @file_put_contents($migrations_version_path, $versions) !== false; } -- cgit v1.2.3