From 0c023a7b5c4f2c8358f33733189b581e593d8e11 Mon Sep 17 00:00:00 2001
From: Thomas Renes <thomas@renesweb.nl>
Date: Fri, 26 Jan 2024 11:08:10 +0100
Subject: Fix: Favicon with protocol-relative URLs have duplicate slashes.
 (#6068)

The URL of favicons with protocol-relative URL's already start with "//" so by adding it again it will result in "http:////url" and the icon will never be retrieved.
---
 lib/favicons.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'lib')

diff --git a/lib/favicons.php b/lib/favicons.php
index 48b649c28..8bfa8e001 100644
--- a/lib/favicons.php
+++ b/lib/favicons.php
@@ -92,7 +92,7 @@ function searchFavicon(string &$url): string {
 
 		// Handle protocol-relative URLs by adding the current URL's scheme
 		if (substr($href, 0, 2) === '//') {
-			$href = ($urlParts['scheme'] ?? 'https') . '://' . $href;
+			$href = ($urlParts['scheme'] ?? 'https') . ':' . $href;
 		}
 
 		$href = SimplePie_IRI::absolutize($baseUrl, $href);
-- 
cgit v1.2.3