From 77e9877316fcfacb26799afdf32d94c8411da80e Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Fri, 31 Dec 2021 17:00:51 +0100 Subject: Add PHPStan (#4021) * Add PHPStan #fix https://github.com/FreshRSS/FreshRSS/issues/4016 https://phpstan.org/ ```sh composer run-script phpstan ``` * More fixes * Fix global variables * Add .phtml * Fix merge https://github.com/FreshRSS/FreshRSS/pull/4090 * Fix more warnings * Fix view errors and enable in CI * ReturnTypeWillChange * Dynamic view type * Fix Minz static/self bug --- p/api/fever.php | 1 + p/api/greader.php | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'p/api') diff --git a/p/api/fever.php b/p/api/fever.php index 1bc5aa8df..684e851a6 100644 --- a/p/api/fever.php +++ b/p/api/fever.php @@ -491,6 +491,7 @@ class FeverAPI /** @var FreshRSS_Category $category */ $category = $categoryDAO->searchById($id); //TODO: Transform to SQL query without loop! Consider FreshRSS_CategoryDAO::listCategories(true) /** @var FreshRSS_Feed $feed */ + $feeds = []; foreach ($category->feeds() as $feed) { $feeds[] = $feed->id(); } diff --git a/p/api/greader.php b/p/api/greader.php index b4fe5e67c..33373293d 100644 --- a/p/api/greader.php +++ b/p/api/greader.php @@ -1116,8 +1116,7 @@ if ($pathInfos[1] === 'accounts') { case 'unread-count': $output = isset($_GET['output']) ? $_GET['output'] : ''; if ($output !== 'json') notImplemented(); - $all = isset($_GET['all']) ? $_GET['all'] : ''; - unreadCount($all); + unreadCount(); break; case 'edit-tag': //http://blog.martindoms.com/2010/01/20/using-the-google-reader-api-part-3/ $token = isset($_POST['T']) ? trim($_POST['T']) : ''; -- cgit v1.2.3