From f3760f138dcbaf7a2190336a0378cf1b2190c9f5 Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Mon, 17 Apr 2023 08:30:21 +0200
Subject: Complete PHPStan Level 6 (#5305)

* Complete PHPStan Level 6
Fix https://github.com/FreshRSS/FreshRSS/issues/4112
And initiate PHPStan Level 7

* PHPStan Level 6 for tests
* Use phpstan/phpstan-phpunit
* Update to PHPStan version 1.10

* Fix mixed bug

* Fix mixed return bug

* Fix paginator bug

* Fix FreshRSS_UserConfiguration

* A couple more Minz_Configuration bug fixes

* A few trivial PHPStan Level 7 fixes

* A few more simple PHPStan Level 7

* More files passing PHPStan Level 7
Add interface to replace removed class from https://github.com/FreshRSS/FreshRSS/pull/5251

* A few more PHPStan Level 7 preparations

* A few last details
---
 p/api/fever.php | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

(limited to 'p/api')

diff --git a/p/api/fever.php b/p/api/fever.php
index 1d3fa6f05..26efe841b 100644
--- a/p/api/fever.php
+++ b/p/api/fever.php
@@ -336,9 +336,8 @@ final class FeverAPI
 		$groups = array();
 
 		$categoryDAO = FreshRSS_Factory::createCategoryDao();
-		$categories = $categoryDAO->listCategories(false, false);
+		$categories = $categoryDAO->listCategories(false, false) ?: [];
 
-		/** @var FreshRSS_Category $category */
 		foreach ($categories as $category) {
 			$groups[] = array(
 				'id' => $category->id(),
@@ -430,28 +429,28 @@ final class FeverAPI
 	}
 
 	/**
-	 * @return integer|false
+	 * @return int|false
 	 */
 	private function setItemAsRead(string $id) {
 		return $this->entryDAO->markRead($id, true);
 	}
 
 	/**
-	 * @return integer|false
+	 * @return int|false
 	 */
 	private function setItemAsUnread(string $id) {
 		return $this->entryDAO->markRead($id, false);
 	}
 
 	/**
-	 * @return integer|false
+	 * @return int|false
 	 */
 	private function setItemAsSaved(string $id) {
 		return $this->entryDAO->markFavorite($id, true);
 	}
 
 	/**
-	 * @return integer|false
+	 * @return int|false
 	 */
 	private function setItemAsUnsaved(string $id) {
 		return $this->entryDAO->markFavorite($id, false);
@@ -540,7 +539,7 @@ final class FeverAPI
 	}
 
 	/**
-	 * @return integer|false
+	 * @return int|false
 	 */
 	private function setFeedAsRead(int $id, int $before) {
 		$before = $this->convertBeforeToId($before);
@@ -548,7 +547,7 @@ final class FeverAPI
 	}
 
 	/**
-	 * @return integer|false
+	 * @return int|false
 	 */
 	private function setGroupAsRead(int $id, int $before) {
 		$before = $this->convertBeforeToId($before);
-- 
cgit v1.2.3