From e56ecf79f65b12ebaa600c961ffa2aab40cebcba Mon Sep 17 00:00:00 2001 From: Frans de Jonge Date: Sat, 25 Feb 2023 12:32:59 +0100 Subject: main.js: fix empty window opened in some cases (#5146) Fixes the following problem: 1. Don't have any article selected (easiest by clicking on "main stream" or a category) 2. Press space 3. A blank window is opened, but since there's no link nothing else happens. --- p/scripts/main.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'p/scripts') diff --git a/p/scripts/main.js b/p/scripts/main.js index 15db36cbe..bca6c2407 100644 --- a/p/scripts/main.js +++ b/p/scripts/main.js @@ -1013,11 +1013,13 @@ function init_shortcuts() { } const link_go_website = document.querySelector('.flux.current a.go_website'); - const newWindow = window.open(); - if (link_go_website && newWindow) { - newWindow.opener = null; - newWindow.location = link_go_website.href; - ev.preventDefault(); + if (link_go_website) { + const newWindow = window.open(); + if (newWindow) { + newWindow.opener = null; + newWindow.location = link_go_website.href; + ev.preventDefault(); + } } return; } -- cgit v1.2.3