From a80a5f48a16e7d232168a7aaa68e9a1804235ce1 Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Mon, 18 Dec 2023 17:59:16 +0100
Subject: Pass PHPStan level 8 (#5946)

* Pass PHPStan level 8
And prepare for PHPStan level 9 https://phpstan.org/user-guide/rule-levels

* Revert wrong replace in comment

* Fix PHPStan level 8

* Update PHPStan and other dev dependencies

* Remove obsolete comment

* noVariableVariables and towards bleedingEdge
https://github.com/phpstan/phpstan-strict-rules
https://phpstan.org/blog/what-is-bleeding-edge

* More bleedingEdge

* A bit more PHPStan level 9

* More PHPStan level 9

* Prepare for booleansInConditions
Ignore int and null

* Revert wrong line

* More fixes

* Fix keep_max_n_unread

* Stricter attribute functions

* Stricter callHooks and more PHPStan level 9

* More typing

* A tiny more
---
 phpstan.neon | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

(limited to 'phpstan.neon')

diff --git a/phpstan.neon b/phpstan.neon
index e262ad984..2335f6ac9 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -1,7 +1,6 @@
 parameters:
 	# TODO: Increase rule-level https://phpstan.org/user-guide/rule-levels
-	level: 7
-	treatPhpDocTypesAsCertain: false
+	level: 8
 	fileExtensions:
 		- php
 		- phtml
@@ -36,6 +35,7 @@ parameters:
 		- TMP_PATH
 		- USERS_PATH
 	reportMaybesInPropertyPhpDocTypes: false
+	treatPhpDocTypesAsCertain: false
 	strictRules:
 		allRules: false
 		booleansInConditions: false	# TODO pass
@@ -43,14 +43,17 @@ parameters:
 		disallowedConstructs: false
 		disallowedLooseComparison: false
 		matchingInheritedMethodNames: true
-		noVariableVariables: false	# TODO pass
+		noVariableVariables: true
 		numericOperandsInArithmeticOperators: true
 		overwriteVariablesWithLoop: true
 		requireParentConstructorCall: true
 		strictCalls: true
 		switchConditionsMatchingType: true
 		uselessCast: true
+	ignoreErrors:
+		# - '#Only booleans are allowed in (a negated boolean|a ternary operator condition|an elseif condition|an if condition|&&|\|\|), (bool|false|int(<[0-9, max]+>)?|true|null|\|)+ given.*#'
 includes:
 	- vendor/phpstan/phpstan-phpunit/extension.neon
 	- vendor/phpstan/phpstan-phpunit/rules.neon
 	- vendor/phpstan/phpstan-strict-rules/rules.neon
+	# - vendor/phpstan/phpstan/conf/bleedingEdge.neon
-- 
cgit v1.2.3