From 6e2f2f1c1e98ecd86aa89c6547beb742d7385d18 Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Thu, 11 May 2023 13:02:04 +0200
Subject: A few additional PHPStan rules (#5388)

A subset of
https://github.com/phpstan/phpstan-strict-rules
---
 tests/app/Models/CategoryTest.php | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

(limited to 'tests/app/Models/CategoryTest.php')

diff --git a/tests/app/Models/CategoryTest.php b/tests/app/Models/CategoryTest.php
index a438afe9e..b332cb524 100644
--- a/tests/app/Models/CategoryTest.php
+++ b/tests/app/Models/CategoryTest.php
@@ -4,8 +4,8 @@ class CategoryTest extends PHPUnit\Framework\TestCase {
 
 	public function test__construct_whenNoParameters_createsObjectWithDefaultValues(): void {
 		$category = new FreshRSS_Category();
-		$this->assertEquals(0, $category->id());
-		$this->assertEquals('', $category->name());
+		self::assertEquals(0, $category->id());
+		self::assertEquals('', $category->name());
 	}
 
 	/**
@@ -13,7 +13,7 @@ class CategoryTest extends PHPUnit\Framework\TestCase {
 	 */
 	public function test_name_whenValidValue_storesModifiedValue(string $input, string $expected): void {
 		$category = new FreshRSS_Category($input);
-		$this->assertEquals($expected, $category->name());
+		self::assertEquals($expected, $category->name());
 	}
 
 	/** @return array<array{string,string}> */
@@ -33,21 +33,21 @@ class CategoryTest extends PHPUnit\Framework\TestCase {
 		$feed_1 = $this->getMockBuilder(FreshRSS_Feed::class)
 			->disableOriginalConstructor()
 			->getMock();
-		$feed_1->expects($this->any())
+		$feed_1->expects(self::any())
 			->method('name')
 			->willReturn('AAA');
 
 		$feed_2 = $this->getMockBuilder(FreshRSS_Feed::class)
 			->disableOriginalConstructor()
 			->getMock();
-		$feed_2->expects($this->any())
+		$feed_2->expects(self::any())
 			->method('name')
 			->willReturn('ZZZ');
 
 		$feed_3 = $this->getMockBuilder(FreshRSS_Feed::class)
 			->disableOriginalConstructor()
 			->getMock();
-		$feed_3->expects($this->any())
+		$feed_3->expects(self::any())
 			->method('name')
 			->willReturn('lll');
 
@@ -58,25 +58,26 @@ class CategoryTest extends PHPUnit\Framework\TestCase {
 		]);
 		$feeds = $category->feeds();
 
-		$this->assertCount(3, $feeds);
-		$this->assertEquals('AAA', $feeds[0]->name());
-		$this->assertEquals('lll', $feeds[1]->name());
-		$this->assertEquals('ZZZ', $feeds[2]->name());
+		self::assertCount(3, $feeds);
+		self::assertEquals('AAA', $feeds[0]->name());
+		self::assertEquals('lll', $feeds[1]->name());
+		self::assertEquals('ZZZ', $feeds[2]->name());
 
+		/** @var FreshRSS_Feed&PHPUnit\Framework\MockObject\MockObject */
 		$feed_4 = $this->getMockBuilder(FreshRSS_Feed::class)
 			->disableOriginalConstructor()
 			->getMock();
-		$feed_4->expects($this->any())
+		$feed_4->expects(self::any())
 			->method('name')
 			->willReturn('BBB');
 
 		$category->addFeed($feed_4);
 		$feeds = $category->feeds();
 
-		$this->assertCount(4, $feeds);
-		$this->assertEquals('AAA', $feeds[0]->name());
-		$this->assertEquals('BBB', $feeds[1]->name());
-		$this->assertEquals('lll', $feeds[2]->name());
-		$this->assertEquals('ZZZ', $feeds[3]->name());
+		self::assertCount(4, $feeds);
+		self::assertEquals('AAA', $feeds[0]->name());
+		self::assertEquals('BBB', $feeds[1]->name());
+		self::assertEquals('lll', $feeds[2]->name());
+		self::assertEquals('ZZZ', $feeds[3]->name());
 	}
 }
-- 
cgit v1.2.3