From b1d24fbdb7d1cc948c946295035dad6df550fb7e Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Fri, 27 Dec 2024 12:12:49 +0100
Subject: PHPStan 2.0 (#7131)

* PHPStan 2.0
fix https://github.com/FreshRSS/FreshRSS/issues/6989
https://github.com/phpstan/phpstan/releases/tag/2.0.0
https://github.com/phpstan/phpstan/blob/2.0.x/UPGRADING.md

* More

* More

* Done

* fix i18n CLI

* Restore a PHPStan Next test
For work towards PHPStan Level 10

* 4 more on Level 10

* fix getTagsForEntry

* API at Level 10

* More Level 10

* Finish Minz at Level 10

* Finish CLI at Level 10

* Finish Controllers at Level 10

* More Level 10

* More

* Pass bleedingEdge

* Clean PHPStan options and add TODOs

* Level 10 for main config

* More

* Consitency array vs. list

* Sanitize themes get_infos

* Simplify TagDAO->getTagsForEntries()

* Finish reportAnyTypeWideningInVarTag

* Prepare checkBenevolentUnionTypes and checkImplicitMixed

* Fixes

* Refix

* Another fix

* Casing of __METHOD__ constant
---
 tests/app/Models/CategoryTest.php | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

(limited to 'tests/app/Models/CategoryTest.php')

diff --git a/tests/app/Models/CategoryTest.php b/tests/app/Models/CategoryTest.php
index f9aa1a280..70bed7477 100644
--- a/tests/app/Models/CategoryTest.php
+++ b/tests/app/Models/CategoryTest.php
@@ -7,17 +7,17 @@ class CategoryTest extends PHPUnit\Framework\TestCase {
 
 	public static function test__construct_whenNoParameters_createsObjectWithDefaultValues(): void {
 		$category = new FreshRSS_Category();
-		self::assertEquals(0, $category->id());
-		self::assertEquals('', $category->name());
+		self::assertSame(0, $category->id());
+		self::assertSame('', $category->name());
 	}
 
 	#[DataProvider('provideValidNames')]
 	public static function test_name_whenValidValue_storesModifiedValue(string $input, string $expected): void {
 		$category = new FreshRSS_Category($input);
-		self::assertEquals($expected, $category->name());
+		self::assertSame($expected, $category->name());
 	}
 
-	/** @return array<array{string,string}> */
+	/** @return list<array{string,string}> */
 	public static function provideValidNames(): array {
 		return [
 			['', ''],
@@ -60,11 +60,11 @@ class CategoryTest extends PHPUnit\Framework\TestCase {
 
 		self::assertCount(3, $feeds);
 		$feed = reset($feeds) ?: FreshRSS_Feed::default();
-		self::assertEquals('AAA', $feed->name());
+		self::assertSame('AAA', $feed->name());
 		$feed = next($feeds) ?: FreshRSS_Feed::default();
-		self::assertEquals('lll', $feed->name());
+		self::assertSame('lll', $feed->name());
 		$feed = next($feeds) ?: FreshRSS_Feed::default();
-		self::assertEquals('ZZZ', $feed->name());
+		self::assertSame('ZZZ', $feed->name());
 
 		/** @var FreshRSS_Feed&PHPUnit\Framework\MockObject\MockObject */
 		$feed_4 = $this->getMockBuilder(FreshRSS_Feed::class)
@@ -79,12 +79,12 @@ class CategoryTest extends PHPUnit\Framework\TestCase {
 
 		self::assertCount(4, $feeds);
 		$feed = reset($feeds) ?: FreshRSS_Feed::default();
-		self::assertEquals('AAA', $feed->name());
+		self::assertSame('AAA', $feed->name());
 		$feed = next($feeds) ?: FreshRSS_Feed::default();
-		self::assertEquals('BBB', $feed->name());
+		self::assertSame('BBB', $feed->name());
 		$feed = next($feeds) ?: FreshRSS_Feed::default();
-		self::assertEquals('lll', $feed->name());
+		self::assertSame('lll', $feed->name());
 		$feed = next($feeds) ?: FreshRSS_Feed::default();
-		self::assertEquals('ZZZ', $feed->name());
+		self::assertSame('ZZZ', $feed->name());
 	}
 }
-- 
cgit v1.2.3