From 6e2f2f1c1e98ecd86aa89c6547beb742d7385d18 Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Thu, 11 May 2023 13:02:04 +0200
Subject: A few additional PHPStan rules (#5388)

A subset of
https://github.com/phpstan/phpstan-strict-rules
---
 tests/cli/i18n/I18nUsageValidatorTest.php | 32 +++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

(limited to 'tests/cli/i18n/I18nUsageValidatorTest.php')

diff --git a/tests/cli/i18n/I18nUsageValidatorTest.php b/tests/cli/i18n/I18nUsageValidatorTest.php
index fdd75bf64..163c0ce82 100644
--- a/tests/cli/i18n/I18nUsageValidatorTest.php
+++ b/tests/cli/i18n/I18nUsageValidatorTest.php
@@ -16,23 +16,23 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase {
 	public function testDisplayReport(): void {
 		$validator = new I18nUsageValidator([], []);
 
-		$this->assertEquals("There is no data.\n", $validator->displayReport());
+		self::assertEquals("There is no data.\n", $validator->displayReport());
 
 		$reflectionTotalEntries = new ReflectionProperty(I18nUsageValidator::class, 'totalEntries');
 		$reflectionTotalEntries->setAccessible(true);
 		$reflectionTotalEntries->setValue($validator, 100);
 
-		$this->assertEquals("  0.0% of translation keys are unused.\n", $validator->displayReport());
+		self::assertEquals("  0.0% of translation keys are unused.\n", $validator->displayReport());
 
 		$reflectionFailedEntries = new ReflectionProperty(I18nUsageValidator::class, 'failedEntries');
 		$reflectionFailedEntries->setAccessible(true);
 		$reflectionFailedEntries->setValue($validator, 25);
 
-		$this->assertEquals(" 25.0% of translation keys are unused.\n", $validator->displayReport());
+		self::assertEquals(" 25.0% of translation keys are unused.\n", $validator->displayReport());
 
 		$reflectionFailedEntries->setValue($validator, 100);
 
-		$this->assertEquals("100.0% of translation keys are unused.\n", $validator->displayReport());
+		self::assertEquals("100.0% of translation keys are unused.\n", $validator->displayReport());
 
 		$reflectionFailedEntries->setValue($validator, 200);
 
@@ -43,8 +43,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase {
 
 	public function testValidateWhenNoData(): void {
 		$validator = new I18nUsageValidator([], []);
-		$this->assertTrue($validator->validate());
-		$this->assertEquals('', $validator->displayResult());
+		self::assertTrue($validator->validate());
+		self::assertEquals('', $validator->displayResult());
 	}
 
 	public function testValidateWhenParentKeyExistsWithoutTransformation(): void {
@@ -59,8 +59,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase {
 			'file1.l1.l2._',
 			'file2.l1.l2._',
 		]);
-		$this->assertTrue($validator->validate());
-		$this->assertEquals('', $validator->displayResult());
+		self::assertTrue($validator->validate());
+		self::assertEquals('', $validator->displayResult());
 	}
 
 	public function testValidateWhenParentKeyExistsWithTransformation(): void {
@@ -75,8 +75,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase {
 			'file1.l1.l2',
 			'file2.l1.l2',
 		]);
-		$this->assertTrue($validator->validate());
-		$this->assertEquals('', $validator->displayResult());
+		self::assertTrue($validator->validate());
+		self::assertEquals('', $validator->displayResult());
 	}
 
 	public function testValidateWhenParentKeyDoesNotExist(): void {
@@ -88,8 +88,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase {
 				'file2.l1.l2._' => $this->value,
 			],
 		], []);
-		$this->assertFalse($validator->validate());
-		$this->assertEquals("Unused key file1.l1.l2._ - \nUnused key file2.l1.l2._ - \n", $validator->displayResult());
+		self::assertFalse($validator->validate());
+		self::assertEquals("Unused key file1.l1.l2._ - \nUnused key file2.l1.l2._ - \n", $validator->displayResult());
 	}
 
 	public function testValidateWhenChildKeyExists(): void {
@@ -104,8 +104,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase {
 			'file1.l1.l2.k1',
 			'file2.l1.l2.k1',
 		]);
-		$this->assertTrue($validator->validate());
-		$this->assertEquals('', $validator->displayResult());
+		self::assertTrue($validator->validate());
+		self::assertEquals('', $validator->displayResult());
 	}
 
 	public function testValidateWhenChildKeyDoesNotExist(): void {
@@ -117,7 +117,7 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase {
 				'file2.l1.l2.k1' => $this->value,
 			],
 		], []);
-		$this->assertFalse($validator->validate());
-		$this->assertEquals("Unused key file1.l1.l2.k1 - \nUnused key file2.l1.l2.k1 - \n", $validator->displayResult());
+		self::assertFalse($validator->validate());
+		self::assertEquals("Unused key file1.l1.l2.k1 - \nUnused key file2.l1.l2.k1 - \n", $validator->displayResult());
 	}
 }
-- 
cgit v1.2.3