From 6e2f2f1c1e98ecd86aa89c6547beb742d7385d18 Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Thu, 11 May 2023 13:02:04 +0200
Subject: A few additional PHPStan rules (#5388)

A subset of
https://github.com/phpstan/phpstan-strict-rules
---
 tests/cli/i18n/I18nValueTest.php | 60 ++++++++++++++++++++--------------------
 1 file changed, 30 insertions(+), 30 deletions(-)

(limited to 'tests/cli/i18n/I18nValueTest.php')

diff --git a/tests/cli/i18n/I18nValueTest.php b/tests/cli/i18n/I18nValueTest.php
index 7a1109a20..4454ea073 100644
--- a/tests/cli/i18n/I18nValueTest.php
+++ b/tests/cli/i18n/I18nValueTest.php
@@ -5,55 +5,55 @@ require_once __DIR__ . '/../../../cli/i18n/I18nValue.php';
 class I18nValueTest extends PHPUnit\Framework\TestCase {
 	public function testConstructorWithoutState(): void {
 		$value = new I18nValue('some value');
-		$this->assertEquals('some value', $value->getValue());
-		$this->assertFalse($value->isIgnore());
-		$this->assertFalse($value->isTodo());
+		self::assertEquals('some value', $value->getValue());
+		self::assertFalse($value->isIgnore());
+		self::assertFalse($value->isTodo());
 	}
 
 	public function testConstructorWithUnknownState(): void {
 		$value = new I18nValue('some value -> unknown');
-		$this->assertEquals('some value', $value->getValue());
-		$this->assertFalse($value->isIgnore());
-		$this->assertFalse($value->isTodo());
+		self::assertEquals('some value', $value->getValue());
+		self::assertFalse($value->isIgnore());
+		self::assertFalse($value->isTodo());
 	}
 
 	public function testConstructorWithTodoState(): void {
 		$value = new I18nValue('some value -> todo');
-		$this->assertEquals('some value', $value->getValue());
-		$this->assertFalse($value->isIgnore());
-		$this->assertTrue($value->isTodo());
+		self::assertEquals('some value', $value->getValue());
+		self::assertFalse($value->isIgnore());
+		self::assertTrue($value->isTodo());
 	}
 
 	public function testConstructorWithIgnoreState(): void {
 		$value = new I18nValue('some value -> ignore');
-		$this->assertEquals('some value', $value->getValue());
-		$this->assertTrue($value->isIgnore());
-		$this->assertFalse($value->isTodo());
+		self::assertEquals('some value', $value->getValue());
+		self::assertTrue($value->isIgnore());
+		self::assertFalse($value->isTodo());
 	}
 
 	public function testClone(): void {
 		$value = new I18nValue('some value');
 		$clonedValue = clone $value;
-		$this->assertEquals('some value', $value->getValue());
-		$this->assertEquals('some value', $clonedValue->getValue());
-		$this->assertFalse($value->isIgnore());
-		$this->assertFalse($clonedValue->isIgnore());
-		$this->assertFalse($value->isTodo());
-		$this->assertTrue($clonedValue->isTodo());
+		self::assertEquals('some value', $value->getValue());
+		self::assertEquals('some value', $clonedValue->getValue());
+		self::assertFalse($value->isIgnore());
+		self::assertFalse($clonedValue->isIgnore());
+		self::assertFalse($value->isTodo());
+		self::assertTrue($clonedValue->isTodo());
 	}
 
 	public function testEqualWhenValueIsIdentical(): void {
 		$value = new I18nValue('some value');
 		$clonedValue = clone $value;
-		$this->assertTrue($value->equal($clonedValue));
-		$this->assertTrue($clonedValue->equal($value));
+		self::assertTrue($value->equal($clonedValue));
+		self::assertTrue($clonedValue->equal($value));
 	}
 
 	public function testEqualWhenValueIsDifferent(): void {
 		$value = new I18nValue('some value');
 		$otherValue = new I18nValue('some other value');
-		$this->assertFalse($value->equal($otherValue));
-		$this->assertFalse($otherValue->equal($value));
+		self::assertFalse($value->equal($otherValue));
+		self::assertFalse($otherValue->equal($value));
 	}
 
 	public function testStates(): void {
@@ -61,23 +61,23 @@ class I18nValueTest extends PHPUnit\Framework\TestCase {
 		$reflectionProperty->setAccessible(true);
 
 		$value = new I18nValue('some value');
-		$this->assertNull($reflectionProperty->getValue($value));
+		self::assertNull($reflectionProperty->getValue($value));
 		$value->markAsDirty();
-		$this->assertEquals('dirty', $reflectionProperty->getValue($value));
+		self::assertEquals('dirty', $reflectionProperty->getValue($value));
 		$value->unmarkAsIgnore();
-		$this->assertEquals('dirty', $reflectionProperty->getValue($value));
+		self::assertEquals('dirty', $reflectionProperty->getValue($value));
 		$value->markAsIgnore();
-		$this->assertEquals('ignore', $reflectionProperty->getValue($value));
+		self::assertEquals('ignore', $reflectionProperty->getValue($value));
 		$value->unmarkAsIgnore();
-		$this->assertNull($reflectionProperty->getValue($value));
+		self::assertNull($reflectionProperty->getValue($value));
 		$value->markAsTodo();
-		$this->assertEquals('todo', $reflectionProperty->getValue($value));
+		self::assertEquals('todo', $reflectionProperty->getValue($value));
 	}
 
 	public function testToString(): void {
 		$value = new I18nValue('some value');
-		$this->assertEquals('some value', $value->__toString());
+		self::assertEquals('some value', $value->__toString());
 		$value->markAsTodo();
-		$this->assertEquals('some value -> todo', $value->__toString());
+		self::assertEquals('some value -> todo', $value->__toString());
 	}
 }
-- 
cgit v1.2.3